Treat semicolons as a delimiter outside of groups. #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies addressparser to treat semicolons like commas when used
outside of a group. I believe this may have been the original intent of
addressparser since there is explicit logic in addressparser.parse that already
treats semicolons identically to commas.
Context: In the Firefox OS email app we allow the user to use the semicolon
character to act as a delimiter in the UI for consistency with other email
client UIs and because there is no valid use for the semicolon apart from a
delimiter in that context. The app currently depends on addressparser to treat
the semicolon as a delimiter identical to a comma when used outside of a group,
but addressparser does not. I think it makes more sense to address this in
addressparser than in our UI in this situation, but we can also do that.
(Note that this was a regression in our UI, but it was probably due to the
change to have our UI use addressparser directly rather than the very naive
approach we were using previously that just looked for commas and spaces and
semicolons.)