chore: clean out TODOs owned by themarwhal (magma#12592)

Signed-off-by: GitHub <noreply@github.com>
emakeev · Aug 5, 2022 · e5a7896 · e5a7896
1 parent 66cfd51
commit e5a7896
Show file tree

Hide file tree

Showing 15 changed files with 9 additions and 36 deletions.
diff --git a/bazel/cpp_repositories.bzl b/bazel/cpp_repositories.bzl
@@ -84,7 +84,7 @@ def cpp_repositories():
         name = "cpp_redis",
         sha256 = "3859289d8254685fc775bda73de03dad27df923423b8ceb375b02d036c03b02f",
         strip_prefix = "cpp_redis-4.3.1",
-        # TODO(@themarwhal): We do not need a custom BUILD file if we upgrade to a more recent version of cpp_redis - GH8321
+        # TODO: We do not need a custom BUILD file if we upgrade to a more recent version of cpp_redis - #8321
         build_file = "//bazel/external:cpp_redis.BUILD",
         url = "https://github.com/cpp-redis/cpp_redis/archive/refs/tags/4.3.1.tar.gz",
     )

diff --git a/bazel/external/cpp_redis.BUILD b/bazel/external/cpp_redis.BUILD
@@ -11,7 +11,7 @@
 
 load("@rules_cc//cc:defs.bzl", "cc_library")
 
-# We can get rid of this once we upgrade cpp-redis to a more up-to-date version - GH8321
+# We can get rid of this once we upgrade cpp-redis to a more up-to-date version - #8321
 cc_library(
     name = "cpp_redis",
     srcs = glob(["sources/**/*.cpp"]),

diff --git a/bazel/third_party_repositories.bzl b/bazel/third_party_repositories.bzl
@@ -19,7 +19,7 @@ def grpc():
         name = "rules_proto_grpc",
         sha256 = "7954abbb6898830cd10ac9714fbcacf092299fda00ed2baf781172f545120419",
         strip_prefix = "rules_proto_grpc-3.1.1",
-        # TODO(@themarwhal): Ships with https://github.com/protocolbuffers/protobuf v3.15.3
-        # Upgrade to latest release once we resolve GH8457
+        # TODO: Ships with https://github.com/protocolbuffers/protobuf v3.15.3
+        # Upgrade to latest release once we resolve #8457
         urls = ["https://github.com/rules-proto-grpc/rules_proto_grpc/archive/3.1.1.tar.gz"],
     )
diff --git a/feg/gateway/services/aaa/protos/BUILD.bazel b/feg/gateway/services/aaa/protos/BUILD.bazel
@@ -22,7 +22,7 @@ cpp_proto_library(
 proto_library(
     name = "context_proto",
     srcs = ["context.proto"],
-    # TODO(@themarwhal): Clean up proto directory structures to be consistent across the project - GH8625
+    # TODO: Clean up proto directory structures to be consistent across the project - #8625
     strip_import_prefix = "/feg/gateway/services/aaa/protos",
 )
 

diff --git a/lte/gateway/c/core/oai/lib/bstr/BUILD.bazel b/lte/gateway/c/core/oai/lib/bstr/BUILD.bazel
@@ -17,6 +17,4 @@ cc_library(
     name = "bstrlib",
     srcs = ["bstrlib.c"],
     hdrs = ["bstrlib.h"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/lte/gateway/c/core/oai/lib/bstr",
 )
diff --git a/lte/gateway/c/core/oai/lib/directoryd/BUILD.bazel b/lte/gateway/c/core/oai/lib/directoryd/BUILD.bazel
@@ -23,8 +23,6 @@ cc_library(
         "GatewayDirectorydClient.hpp",
         "directoryd.hpp",
     ],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/lte/gateway/c/core/oai/lib/directoryd",
     deps = [
         "//orc8r/gateway/c/common/async_grpc:async_grpc_receiver",
         "//orc8r/gateway/c/common/service_registry",

diff --git a/lte/gateway/c/core/oai/lib/event_client/BUILD.bazel b/lte/gateway/c/core/oai/lib/event_client/BUILD.bazel
@@ -17,8 +17,6 @@ cc_library(
     name = "eventd_client",
     srcs = ["EventClientAPI.cpp"],
     hdrs = ["EventClientAPI.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/lte/gateway/c/core/oai/lib/event_client",
     deps = [
         "//orc8r/gateway/c/common/eventd:eventd_client",
         "//orc8r/protos:eventd_cpp_grpc",

diff --git a/orc8r/gateway/c/common/async_grpc/BUILD.bazel b/orc8r/gateway/c/common/async_grpc/BUILD.bazel
@@ -14,12 +14,10 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
 package(default_visibility = ["//visibility:public"])
 
 cc_library(
-    # TODO(@themarwhal) The library name will match the file names once we resolve GH8467
+    # TODO The library name will match the file names once we resolve #8467
     name = "async_grpc_receiver",
     srcs = ["GRPCReceiver.cpp"],
     hdrs = ["includes/GRPCReceiver.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/async_grpc",
     deps = [
         "//orc8r/gateway/c/common/logging",
         "@com_github_grpc_grpc//:grpc++",

diff --git a/orc8r/gateway/c/common/config/BUILD.bazel b/orc8r/gateway/c/common/config/BUILD.bazel
@@ -17,8 +17,6 @@ cc_library(
     name = "yaml_utils",
     srcs = ["YAMLUtils.cpp"],
     hdrs = ["YAMLUtils.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/config",
     deps = [
         "@yaml-cpp//:yaml-cpp",
     ],
@@ -28,8 +26,6 @@ cc_library(
     name = "mconfig_loader",
     srcs = ["MConfigLoader.cpp"],
     hdrs = ["includes/MConfigLoader.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/config",
     deps = [
         "//orc8r/gateway/c/common/logging",
         "@com_google_protobuf//:protobuf",
@@ -40,10 +36,8 @@ cc_library(
 cc_library(
     name = "service_config_loader",
     srcs = ["ServiceConfigLoader.cpp"],
-    # TODO(@themarwhal): Remove includes/ project directories - GH8446
+    # TODO: Remove includes/ project directories - #8446
     hdrs = ["includes/ServiceConfigLoader.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/config",
     deps = [
         ":yaml_utils",
         "//orc8r/gateway/c/common/logging",

diff --git a/orc8r/gateway/c/common/ebpf/BUILD.bazel b/orc8r/gateway/c/common/ebpf/BUILD.bazel
@@ -19,6 +19,4 @@ cc_library(
         "EbpfMap.h",
         "EbpfMapUtils.h",
     ],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/ebpf",
 )
diff --git a/orc8r/gateway/c/common/eventd/BUILD.bazel b/orc8r/gateway/c/common/eventd/BUILD.bazel
@@ -16,10 +16,8 @@ package(default_visibility = ["//visibility:public"])
 cc_library(
     name = "eventd_client",
     srcs = ["EventdClient.cpp"],
-    # TODO(@themarwhal): Remove includes/ project directories - GH8446
+    # TODO: Remove includes/ project directories - #8446
     hdrs = ["includes/EventdClient.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/eventd",
     deps = [
         "//orc8r/gateway/c/common/async_grpc:async_grpc_receiver",
         "//orc8r/gateway/c/common/config:service_config_loader",

diff --git a/orc8r/gateway/c/common/logging/BUILD.bazel b/orc8r/gateway/c/common/logging/BUILD.bazel
@@ -19,7 +19,5 @@ cc_library(
         "magma_logging.hpp",
         "magma_logging_init.hpp",
     ],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/logging",
     deps = ["@com_github_google_glog//:glog"],
 )
diff --git a/orc8r/gateway/c/common/sentry/BUILD.bazel b/orc8r/gateway/c/common/sentry/BUILD.bazel
@@ -27,16 +27,13 @@ cc_library(
     name = "sentry_wrapper",
     srcs = ["SentryWrapper.cpp"],
     hdrs = ["includes/SentryWrapper.hpp"],
-    # TODO(@themarwhal): Enable Sentry by default - GH9302
     copts = select({
         ":disable_sentry_native": [],
         "//conditions:default": [
             "-DSENTRY_ENABLED",
             "-DSENTRY_BUILD_STATIC",
         ],
     }),
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/sentry",
     deps = select({
         ":disable_sentry_native": sentry_deps,
         "//conditions:default": sentry_deps + ["@sentry_native//:sentry"],

diff --git a/orc8r/gateway/c/common/service303/BUILD.bazel b/orc8r/gateway/c/common/service303/BUILD.bazel
@@ -21,16 +21,14 @@ cc_library(
         "MetricsSingleton.cpp",
         "ProcFileUtils.cpp",
     ],
-    # TODO(@themarwhal): Remove includes/ project directories - GH8446
+    # TODO: Remove includes/ project directories - #8446
     hdrs = [
         "ProcFileUtils.hpp",
         "includes/MagmaService.hpp",
         "includes/MetricsHelpers.hpp",
         "includes/MetricsRegistry.hpp",
         "includes/MetricsSingleton.hpp",
     ],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/service303",
     deps = [
         "//orc8r/gateway/c/common/service_registry",
         "//orc8r/protos:service303_cpp_grpc",

diff --git a/orc8r/gateway/c/common/service_registry/BUILD.bazel b/orc8r/gateway/c/common/service_registry/BUILD.bazel
@@ -17,8 +17,6 @@ cc_library(
     name = "service_registry",
     srcs = ["ServiceRegistrySingleton.cpp"],
     hdrs = ["includes/ServiceRegistrySingleton.hpp"],
-    # TODO(@themarwhal): Migrate to using full path for includes - GH8299
-    strip_include_prefix = "/orc8r/gateway/c/common/service_registry",
     deps = [
         "//orc8r/gateway/c/common/config:service_config_loader",
         "@com_github_grpc_grpc//:grpc++",