New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean out TODOs owned by themarwhal #12592

Merged

themarwhal merged 1 commit into magma:master from themarwhal:cleanup-todos

Apr 28, 2022

Member

themarwhal commented Apr 28, 2022 •

edited

Signed-off-by: GitHub noreply@github.com

Summary

Cleaning out TODOs owned by me as I'm ramping off the project

The path prefix TODOs can be resolved
TODOs owned by me that still need action have been added to the cleanup section here: bazel: Main issue for tracking all Bazel efforts #11283

I also modified the github issue comment from "GHXXX" to "#XXX". This enables VSCode to preview the GitHub issue on hover, which seems nice :D

Test Plan

CI

Additional Information

This change is backwards-breaking

themarwhal requested review from a team and LKreutzer

April 28, 2022 14:16

pull-request-size bot added the size/M label

Contributor

github-actions bot commented Apr 28, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions bot added component: agw component: feg labels

themarwhal force-pushed the cleanup-todos branch from 6ed268e to eaeebdd Compare

April 28, 2022 14:18


          chore: clean out TODOs owned by themarwhal

058837c

Signed-off-by: GitHub <noreply@github.com>

themarwhal force-pushed the cleanup-todos branch from eaeebdd to 058837c Compare

April 28, 2022 14:26

maxhbr approved these changes

View reviewed changes

Member

maxhbr left a comment

LGTM

Contributor

github-actions bot commented Apr 28, 2022

feg-workflow

    2 files 202 suites 39s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs 385 ✔️ 0 💤 0 ❌

Results for commit 058837c.

Contributor

github-actions bot commented Apr 28, 2022

cloud-workflow

    7 files 356 suites 2m 51s ⏱️
974 tests 974 ✔️ 0 💤 0 ❌

Results for commit 058837c.

themarwhal enabled auto-merge (squash)

April 28, 2022 15:16

LKreutzer approved these changes

View reviewed changes

Contributor

LKreutzer left a comment

Looks good - nice touch with the VSCode previews! :)

LKreutzer added the bazel label

Contributor

github-actions bot commented Apr 28, 2022

agw-workflow

    77 files   122 suites 7m 36s ⏱️
1 158 tests 1 149 ✔️ 9 💤 0 ❌
1 159 runs 1 150 ✔️ 9 💤 0 ❌

Results for commit 058837c.

themarwhal merged commit be12098 into magma:master

emakeev pushed a commit to emakeev/magma that referenced this pull request


          chore: clean out TODOs owned by themarwhal (magma#12592)

e5a7896

Signed-off-by: GitHub <noreply@github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment