Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multi-weight boost histograms and other minor stuff #45

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

emanca
Copy link
Owner

@emanca emanca commented Apr 28, 2021

the greatest news in this PR is the implementation of support for multi-weighted boost histograms, enabling for an optimisation of weight systematics. Other minor but nice implementations:

  • setting the number of threads in the constructor of RDFtree
  • removed support for RResultPtr to be carried by modules - only nodes can dump histograms, snapshots, etc
  • added some useful metadata to the boost-histograms output: axes edges
  • histograms are already reshaped in the right way, no need for the user to remember the original binning

this PR addresses at least partially a number of open issues: #44 #43

@emanca emanca added the enhancement New feature or request label Apr 28, 2021
@emanca emanca added this to the framework major update milestone Apr 28, 2021
@emanca emanca merged commit 804ba7e into master Apr 28, 2021
@emanca emanca deleted the nested_histograms branch April 28, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant