-
Notifications
You must be signed in to change notification settings - Fork 493
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(@contract-app): fix contracts app tests (#1982)
* refactor(@embark/dapps/tests/app): use function syntax These changes don't fix the race conditions related to the test dapp's tests but are a step in the right direction. * refactor(@embark/dapps/tests/contracts): adjustments to get tests passing Further refactoring is needed re: potentially duplicated or overlapping logic in `packages/plugins/solidity-tests` and `packages/core/utils/src/solidity/remapImports.ts`, as well in disabled test dapp tests * test(dapps/tests/app): temporarily disable intermittently failing tests They are failing because of a race condition; once that race condition has been fixed these tests should be reenabled. * fix(@embark/solidity-tests): fix importing the library for the tests
- Loading branch information
1 parent
183d9a0
commit 6e9635c
Showing
8 changed files
with
25 additions
and
175 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
pragma solidity ^0.4.25; | ||
import 'remix_tests.sol'; | ||
|
||
contract MyTest { | ||
uint i = 0; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters