Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(core/engine): make serviceMonitor a module group
`Engine`s internal `coreComponents()` API sets up a bunch of things like a `ProcessManager` and the `ServiceMonitor`. The `ServiceMonitor` activates itself on `embark:engine:started` and practically monitors registered services until the process has been explicitly stopped. There are some commands that don't actually need service monitoring like `build` and a future `exec` command that's in the making. For those cases it's useful to have them disable the service monitor when `coreComponents()` is used. This commit moves the `ServiceMonitor` instantiation out of `coreComponents()` and introduces a new module group instead. This then lets commands that need service monitoring instantiate it explicitly.
- Loading branch information
Showing
2 changed files
with
15 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters