test: added tests #250
Merged
test: added tests #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshraj
reviewed
Jul 13, 2023
| @@ -0,0 +1,46 @@ | |||
| # ruff: noqa: E501 | |||
There was a problem hiding this comment.
Any specific reason to add this? :D
There was a problem hiding this comment.
otherwise it complains about all the doc strings.
tests/embedchain/test_add.py
Outdated
| @@ -0,0 +1,26 @@ | |||
| # ruff: noqa: E501 | |||
There was a problem hiding this comment.
Let's remove this from all the test files. We only want to specific specific lines and not all of the file.
There was a problem hiding this comment.
that's going to be a lot of lines and decrease readability.
There was a problem hiding this comment.
Discussed offline with @cachho and we are going to increase the line length to 120 chars.
|
@deshraj waiting for your review, since you are driving adding tests feature. |
deshraj
approved these changes
Jul 16, 2023
cachho
added a commit
to cachho/embedchain
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of these are smart, some are more simple. But better than nothing I guess.