Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: documentation handling #296

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

cachho
Copy link
Contributor

@cachho cachho commented Jul 17, 2023

Description

I think it's redundant to ask if the change requires a documentation update, because that question is already part of the checklist.

Instead what's missing is the option for a type of change the IS a documentation update.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@deshraj deshraj merged commit 07ba65d into embedchain:main Jul 17, 2023
3 checks passed
cachho added a commit to cachho/embedchain that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants