Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom app #313

Merged
merged 43 commits into from
Jul 18, 2023
Merged

Feat/custom app #313

merged 43 commits into from
Jul 18, 2023

Conversation

cachho
Copy link
Contributor

@cachho cachho commented Jul 18, 2023

Description

I have basically rewritten the whole app.

  1. Added custom app
  2. Shared code between apps
  3. Improved open source app (takes config now)
  4. Error handling
  5. documentation update

Todo:

docs: add providers
docs: add separate custom config for the different App configs.

This itself shouldn't really be breaking, the breaking changes were already accepted in #305

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests
  • Manual tests (example in docs /advanced/app_types#customapp)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@cachho cachho added the enhancement New feature or request label Jul 18, 2023
@cachho cachho linked an issue Jul 18, 2023 that may be closed by this pull request
@cachho
Copy link
Contributor Author

cachho commented Jul 18, 2023

Not sure what's wrong with the tests.

@taranjeet taranjeet merged commit adb7206 into mem0ai:main Jul 18, 2023
0 of 3 checks passed
cachho added a commit to cachho/embedchain that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Update required
2 participants