Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with spaces when setting tool flag options #51

Closed
MarkHillHuawei opened this issue Mar 9, 2020 · 3 comments
Closed

Problems with spaces when setting tool flag options #51

MarkHillHuawei opened this issue Mar 9, 2020 · 3 comments
Assignees
@PaoloS02
Labels
bug Something isn't working fixed An issue raised has been fixed

Comments

@MarkHillHuawei
Copy link

I have noticed that if a user puts extra spaces in their tool options, for example, --cflags “-Os–mtune=size” instead of --cflags “-Os–mtune=size” the build fails complaining about a non existent file. This can be a bit confusing, it certainly confused me until I realized what was going on. This is due to the split(sep=’ ‘) in build_all.py creating empty elements in the cflags list e.g. [ ‘-Os’, ‘’, ‘-mtune=size’ ].

I think all the split(sep=' ') commands just need to be split() which ignores multiple spaces by default.
@jeremybennett jeremybennett self-assigned this Mar 9, 2020
@jeremybennett jeremybennett added the bug Something isn't working label Mar 9, 2020
@jeremybennett
Copy link
Collaborator

Hi @MarkHillHuawei ,

Thanks for raising this. I'll inviestigate.

Best wishes,

Jeremy

PaoloS02 pushed a commit to PaoloS02/embench-iot that referenced this issue Apr 20, 2020
Remove split space separator (embench#51)
9f3326b 
The split separator cause the parsing of the arguments to fail if multiple
spaces are used. Without specifying the separator the parsing is more robust.

Files changed:

        * build_all.py: removed split space separator.
jeremybennett pushed a commit that referenced this issue Apr 20, 2020
@PaoloS02
Remove split space separator (#51) (#55)
86f4a1c 
The split separator cause the parsing of the arguments to fail if multiple
spaces are used. Without specifying the separator the parsing is more robust.

Files changed:

        * build_all.py: removed split space separator.

Co-authored-by: Paolo Savini <paolo.savini@gmail.com>
@PaoloS02
Copy link
Contributor

Thank you for the tip @MarkHillHuawei ,
fixed that now.

Kind regards,
Paolo

@PaoloS02
Copy link
Contributor

The fix is on master. I would close this issue.

Thank you again.
Paolo

@jeremybennett jeremybennett added the fixed An issue raised has been fixed label Apr 30, 2020
widlarizer pushed a commit to widlarizer/embench-iot that referenced this issue Nov 29, 2023
@petertorelli
Merge pull request embench#51 from eembc/portlayer_docs
d5ac817 
Portlayer & documentaiton update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaoloS02 PaoloS02

Labels
bug Something isn't working fixed An issue raised has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremybennett @PaoloS02 @MarkHillHuawei