How do I extend GrowlNotifications?

[farzher]

You have iconType defined like this in the itemViewClass

iconType: (function() {
    var hash, type;
    type = this.get('content.type');
    hash = {
      'info': 'fa-bullhorn',
      'success': 'fa-check',
      'warning': 'fa-exclamation',
      'danger': 'fa-times'
    };
    return hash[type] || '';
  }).property('content.type')

How can I extend this with a basic piece of custom behavior?
I just want to change return hash[type] || ''; to return hash[type] || type; so I'm able to also pass in custom font awesome icons.

I'm stuck, I can't figure this out without hacking.

[rizkytahara]

+1

[asaf]

Change and send a PR, I'll merge

[farzher]

Well, in this case I guess that change is good for everyone, but I was asking how can I extend edits for just my application, so I can have full control over my own app, but still receive updates from your library.

For example I also check type to see if it contains a /, if it does I render an img tag with type as the src, otherwise I render it as a font-awesome icon. Not all of my edits should be pushed to bootstrap-for-ember

[asaf]

If a component is not extensible enough then you can extend the component
and override some of its methods to suite your needs.

On Wed, Jul 23, 2014 at 9:04 PM, Stephen Kamenar notifications@github.com
wrote:

Well, in this case I guess that change is good for everyone, but I was
asking how can I extend edits for just my application, so I can have full
control over my own app, but still receive updates from your library.

For example I also check type to see if it contains a /, if it does I
render an img tag with type as the src, otherwise I render it as a
font-awesome icon. Not all of my edits should be pushed to
bootstrap-for-ember

—
Reply to this email directly or view it on GitHub
#153 (comment)
.

[farzher]

Well, that's my question, how do I extend iconType method?

It's part of the itemViewClass, I'm not sure how to extend that. (Normal component methods are np)

[asaf]

You can just do:
MyNotif = GrowlNotiComp.extend
overrideSomeMethod: ->
#your implementation here

Specifically regarding your need, this component is not really a 'bootstrap' one, im planning to push this into: https://github.com/indexiatech/ember-components

It will have more configuration than this one,

So track it, it will have the ability to configure icons easily.
indexiatech/ember-components#30