Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes jQuery from the tests & demo app #30

Merged
merged 6 commits into from
Mar 21, 2018
Merged

removes jQuery from the tests & demo app #30

merged 6 commits into from
Mar 21, 2018

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 21, 2018

Thanks mostly to @cibernox's hard work we have nearly everything working without jQuery.

The final issue is that there are some acceptance tests that use checkbox, and apparently Ember's own checkbox component depends on jQuery until very recently.

@cibernox
Copy link
Collaborator

@ef4 to fix tests in < 3.0 you only have to modify the ember-try config to add ember-native-dom-event-dispatcher to 2.X scenarios

@cibernox
Copy link
Collaborator

Example:

    {
      name: 'ember-lts-2.12',
      npm: {
        devDependencies: {
          'ember-native-dom-event-dispatcher': '^0.6.4',
          'ember-source': '~2.12.0'
        }
      }
    },

@ef4
Copy link
Contributor Author

ef4 commented Mar 21, 2018

Yup, I just figured that out from looking at what some of your addons are doing. :-)

@ef4 ef4 merged commit dc3a7c1 into master Mar 21, 2018
@ef4 ef4 deleted the no-jquery branch March 21, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants