Add missing tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two failing tests to highlight bugs and a passing but previously missing test. The missing test added is for calling `set` which was destructured from `import Ember from 'ember'` One failing test is to handle the case where `Ember.computed` is called from an import that isn't named `Ember`, eg ``` import E from 'ember'; E.computed() ``` Another failing test illustrates that ember import bindings are clobbered if followed by any other default import, as in: ``` import Ember from 'ember'; import AnythingElse from 'anywhere'; ```
hjdivad
force-pushed
the
hjdivad/no-set-cp-bug
branch
from
fb7be47
to
c84bd0d
Compare
|
cc @rwjblue |
|
Hehe. Confirm. Really need to get that wired up right through testem and whatnot. |
|
OK, just did a pass across this rule to fix the largest issues that @hjdivad pointed out above. I pushed the fix commits directly to this branch, so it should be ready for review... |
scalvert
reviewed
Oct 2, 2017
tests/lib/rules/no-side-effect-cp.js
Outdated
| code: ` | ||
| import Ember from 'ember'; | ||
| import SomethingElse from 'something-else'; | ||
| const { set } = Ember; |
There was a problem hiding this comment.
Can we space in these lines in to line them up with the code below. It's a bit hard to read like this.
scalvert
reviewed
Oct 2, 2017
tests/lib/rules/no-side-effect-cp.js
Outdated
| { | ||
| code: ` | ||
| import Ember from 'ember'; | ||
| const { set } = Ember; |
scalvert
reviewed
Oct 2, 2017
tests/lib/rules/no-side-effect-cp.js
Outdated
| }, | ||
| { | ||
| code: ` | ||
| import E from 'ember'; |
scalvert
reviewed
Oct 2, 2017
lib/utils/computed-property.js
Outdated
| } | ||
| return false; | ||
| } | ||
|
|
||
| module.exports = function isCPGetter(node) { | ||
| return isCPDesc(node, 'get') || isCPAccessor(node) || isPrototypeExtCP(node); | ||
| module.exports = function isCPGetter(node, importedCPName, importedEmberName) { |
There was a problem hiding this comment.
For some reason it feels more natural to have importedEmberName come before importedCPName, like in hierarchical order.
scalvert
reviewed
Oct 2, 2017
lib/utils/computed-property.js
Outdated
| return true; | ||
| } | ||
| if (callee.type === 'MemberExpression') { | ||
| let caller = getCaller(callee); | ||
| return caller === 'Ember.computed' || caller === 'Em.computed'; | ||
| return caller === 'Ember.computed' || caller === 'Em.computed' || caller === importedEmberName + '.computed'; |
There was a problem hiding this comment.
You could template string ${importedEmberName}.computed
scalvert
requested changes
Oct 2, 2017
|
LGTM 👍 |
Fixes a number of the errors previously identified, as well as a few additional ones (tests added in this commit).
rwjblue
force-pushed
the
hjdivad/no-set-cp-bug
branch
from
bc997b1
to
23bbb0b
Compare
|
@scalvert - I believe that the latest push addresses all of your comments. Let me know if you spot anything else... |
|
LGTM |
scalvert
approved these changes
Oct 3, 2017
mwpastore
pushed a commit
to mwpastore/eslint-plugin-ember-best-practices
that referenced
this pull request
Nov 29, 2017
* Add missing tests This adds two failing tests to highlight bugs and a passing but previously missing test. The missing test added is for calling `set` which was destructured from `import Ember from 'ember'` One failing test is to handle the case where `Ember.computed` is called from an import that isn't named `Ember`, eg ``` import E from 'ember'; E.computed() ``` Another failing test illustrates that ember import bindings are clobbered if followed by any other default import, as in: ``` import Ember from 'ember'; import AnythingElse from 'anywhere'; ``` * Clean up no-side-effect-cp rule. Fixes a number of the errors previously identified, as well as a few additional ones (tests added in this commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of failing tests and a passing but previously missing test.
The missing test added is for calling
setwhich was destructured fromimport Ember from 'ember'One failing test is to handle the case where
Ember.computedis called from an import that isn't namedEmber, egAnother failing test illustrates that ember import bindings are clobbered if followed by any other default import, as in:
tl;dr things to fix
contextargEmber.computed