Colocate component templates #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why but it seems as if this has triggered a bug in the codemod. It logged this error: ❌ Did not move '/home/main/Code/ember-ecosystem/ember-bootstrap/addon/templates/components/bs-button-group.hbs' because it was imported by multiple components: /components/bs-button-group.js /components/bs-button.js But <BsButton> was not using that template at all. 😕
simonihmig
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Thanks for working on this!
Why has bs-tooltip/element.hbs been renamed to bs-contextual-help/element.hbs?
This seems odd, as the bs-contextual-help/element component is basically an abstract class, extended from both by bs-tooltip/element and bs-popover/element.
Good catch. I got confused by the template import in |
simonihmig
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most work was done by ember-component-template-colocation-migrator. Only needed to fix some edge cases, which triggered bugs.
Component template colocation is available since Ember 3.13. As we require Ember 3.16+ and Ember CLI 3.15+ this shouldn't be a breaking change for any consumer.