drop private @class argument of <BsModal> #1755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@class
argument of<BsModal>
was added a long-time ago when that component was refactored to a tag-less component. It was not documented as a public API. A consumer can useclass
attribute instead. I think it is time to remove it.There are some other components as well for which we have private
@class
argument:<BsAccordion::Item::Body>
<BsDropdown::Menu>
<BsLinkTo>
<BsNavbar::LinkTo>
<BsPopover>
and<BsPopover::Element>
<BsTooltip>
and BsTooltip::Element`For
<BsAccordion::Item::Body>
,<BsDropdown::Menu>
,<BsPopover>
,<BsPopover::Element>
,<BsTooltip>
and<BsTooltip::Element>
I created pull requests to drop it as well: #1756, #1758, #1759 and #1760For
<BsLinkTo>
and<BsNavbar::LinkTo>
we can not drop the@class
argument because we need to set the class on a yielded component instance.https://github.com/kaliber5/ember-bootstrap/blob/f2ca93d7bf3ebd50de695f1c2800f7694e9bb07d/addon/components/bs-nav.hbs#L6
https://github.com/kaliber5/ember-bootstrap/blob/f2ca93d7bf3ebd50de695f1c2800f7694e9bb07d/addon/components/bs-navbar.hbs#L8
For
<BsLinkTo>
we could reduce the number of cases in which we need to use@class
argument. Created a pull request to use class attribute for one case, in which it was possible. #1757