Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop private @class argument of <BsModal> #1755

Merged
merged 1 commit into from Feb 25, 2022
Merged

drop private @class argument of <BsModal> #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions addon/components/bs-modal.hbs
View file
Open in desktop
Expand Up @@ -26,7 +26,6 @@
) as |Dialog|}}
{{#if this._renderInPlace}}
<Dialog
class={{@class}}
{{create-ref "modalElement"}}
...attributes
>
Expand All @@ -48,7 +47,6 @@
{{else}}
{{#in-element this.destinationElement insertBefore=null}}
<Dialog
class={{@class}}
{{create-ref "modalElement"}}
...attributes
>
Expand Down
10 changes: 0 additions & 10 deletions tests/integration/components/bs-modal-test.js
View file
Open in desktop
Expand Up @@ -144,16 +144,6 @@ module('Integration | Component | bs-modal', function (hooks) {
assert.dom('.modal').hasAttribute('aria-labelledby', modalTitleId);
});

test('it passes along class attribute', async function (assert) {
await render(hbs`
<BsModal @fade={{false}} @class="custom">
template block text
</BsModal>
`);

assert.dom('.modal.custom').exists({ count: 1 });
});

test('it passes along HTML attributes', async function (assert) {
await render(hbs`
<BsModal @fade={{false}} class="custom" role="alert" data-test>
Expand Down