doen't use path.join for urls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flecno Thanks for this. What is the reason for the change to the test file? That gzipped assets property should be an array of file names. Not file paths. So the leading slash doesn't really make sense. |
|
Year. It's unsatisfying. I will look into this tomorrow. It seems there is a empty string inside the list. Perhaps the test isn't exact enough or the join has to be more safe... |
* the path module is for filesystem path. It is plaform agnostic and will add backslashs on windows. That is not the expected behavior.
|
@achambers The path are only joined if the prefix is not empty now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path module is for filesystem path. It is plaform agnostic and will add backslashs on windows. That is not the expected behavior.
I can not test it on windows, because I doen't have windows. And I'm not sure if the changed path in the
index-nodetest.jsis ok. Are leading Slashs OK for S3?