Configure Cache-Control and Expires headers on the uploaded files. #53
Conversation
| @@ -50,7 +50,7 @@ | |||
| "core-object": "^1.1.0", | |||
| "ember-cli-babel": "^5.0.0", | |||
| "ember-cli-deploy-plugin": "^0.2.2", | |||
| "lodash": "^3.9.3", | |||
| "lodash": "^4.11.1", | |||
There was a problem hiding this comment.
@YoranBrondsema why are we updating this?
I ask because lodash has been giving us quite a bit of gas lately in different plugins and I've seen some weird npm incompatibilities around it
There was a problem hiding this comment.
@ghedamat No particular reason but to keep up-to-date. I wasn't aware of any recent problems with lodash, I can revert it back to 3 no problems.
There was a problem hiding this comment.
seems stupid but yeah let's revert and maybe do this in another pr
so we can release a beta and get someone to test it just in case.
There was a problem hiding this comment.
I understand, no problem.
|
@YoranBrondsema LGTM just that comment on lodash /cc @lukemelia |
|
@ghedamat Any news on when this can be merged? We'd like to start using this functionality ourselves. |
|
done :) thanks! will try to cut a release later today a patch bump should be enough |
|
@ghedamat Perfect thanks! |
This PR adds the ability to configure the
Cache-ControlandExpiresheaders through thecacheControlandexpiresconfiguration options.Solves #52