Loosen aws-sdk version

[ryansch]

What Changed & Why

The current aws-sdk version string ~2.3.19 forces an old version of aws-sdk due to brokenness in 2.4.0. The signing issues mentioned #59 in seem to have been fixed in 2.4.1.

Personally I'm blocked on the ECS Credential stuff added in 2.4.7. 2.6.12 is current newest release.

Related issues

#59
aws/aws-sdk-js@v2.4.0...v2.4.1

[ghedamat]

@ryansch can you confirm that an end to end deploy with this update works? (we sadly don't have an end to end integration test)

also, would it be more prudent to lock to ~2.6.12 instead of ^ to avoid problems like last time?

[ryansch]

I'll fork and confirm.

The problem is that when aws releases 2.7.x we'll be stuck on 2.6.x if we use ~2.6.12. The problem here was one bad release. We should have just blacklisted 2.4.0 (ex: ~2.3.19 || ^2.4.1).

[ghedamat]

fair enough,

if your smoke test passes and you can use this locally I think I'm ok in merging then!

[lukemelia]

My semver is not excellent, but can't we use ~2.6 to get the latest 2.x?

[lukemelia]

Scratch that suggestion, doesn't do what I thought it did per https://semver.npmjs.com/

[ghedamat]

@lukemelia the code in this PR that uses ^ will do what both you and @ryansch are looking for, I was just being overly prudent after getting burned last time but this is probably fine :)

[ryansch]

Ok I have a successful deploy with https://www.npmjs.com/package/ember-cli-deploy-s3-outstand (deployed from https://github.com/outstand/ember-cli-deploy-s3/tree/test-loosen-aws-sdk-version)

[lukemelia]

Thanks @ryansch. Released as 0.4.0