New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup / fix some svelte related functionality. #63

Merged

rwjblue merged 2 commits into ember-cli:master from rwjblue:loosen-if-statement-parent-condition

May 22, 2018

Member

rwjblue commented May 22, 2018

Ensure (in production) that all svelte flags are replaced by their evaluated boolean value.
Ensure that conditions like if (DEPRECATED_FLAG && otherThing()){ } receive an error in their consequent.

rwjblue added 2 commits

May 22, 2018 11:01


          Always replace svelte flag with boolean value in non-debug builds.

ce71a5c


          Allow svelte flag to in logical expr in an if statement.

97fa9ba

rwjblue merged commit 65ae930 into ember-cli:master

rwjblue deleted the loosen-if-statement-parent-condition branch

May 22, 2018 15:07

Turbo87 added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment