Make ensureImport lazy #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the logic for ensuring the Ember import lazy. This allows it to handle cases where a different transform has also added the Ember import already, and so it can use it lazily. Also makes the logic generalized (in case we ever need to import from a different module in the future).
pzuraq
force-pushed
the
make-ensure-import-lazy
branch
from
81b8139
to
6a9a9d7
Compare
rwjblue
approved these changes
Feb 22, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the logic for ensuring the Ember import lazy. This allows it to
handle cases where a different transform has also added the Ember import
already, and so it can use it lazily. Also makes the logic generalized
(in case we ever need to import from a different module in the future).