Refactor to work when before babel-plugin-transform-es2015-template-literals. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…015-template-literals.
…iterals. Prior to this change, when `babel-plugin-transform-es2015-template-literals` was present in the `plugins` array its `TaggedTemplateExpression` visitor was always ran prior to this plugins `Identifier` plugin (because the `TaggedTemplateExpression` is "seen" before the `Identifier`). Since the `babel-plugin-transform-es2015-template-literals` plugin then transforms the tagged template literal into a custom transpiled version (for use in runtime) the `babel-plugin-htmlbars-inline-precompile` plugin never functioned properly. The refactor also seems to simplify (IMO) and make this a bit easier to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when
babel-plugin-transform-es2015-template-literalswas present in thepluginsarray itsTaggedTemplateExpressionvisitor was always ran prior to this pluginsIdentifierplugin (because theTaggedTemplateExpressionis "seen" before theIdentifier).Since the
babel-plugin-transform-es2015-template-literalsplugin then transforms the tagged template literal into a custom transpiled version (for use in runtime) thebabel-plugin-htmlbars-inline-precompileplugin never functioned properly.The refactor also seems to simplify (IMO) and make this a bit easier to reason about.
It may be easier to review this as independent commits (the first 3 are just setting up our testing mechanisms).