Add ability to parse scope function (allow strict mode templates to be more resilient to module cycles). #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Mar 22, 2021
index.js
Outdated
Comment on lines
44
to
46
| console.warn( | ||
| 'Passing an object as the `scope` property to inline templates has been deprecated. Please pass an arrow function that returns an object expression instead.' | ||
| ); |
There was a problem hiding this comment.
Hmm, when do we expect this to happen? Is it "basically never"?
There was a problem hiding this comment.
Using it? Practically speaking, yes, this API hasn't been out long and there aren't many users
rwjblue
requested changes
Mar 22, 2021
pzuraq
force-pushed
the
add-scope-function-parsing
branch
from
ffb800c
to
c800c57
Compare
Adds the ability to parse scope functions as well as object expressions, and deprecates parsing object expressions.
pzuraq
force-pushed
the
add-scope-function-parsing
branch
from
c800c57
to
20fe896
Compare
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to parse scope functions as well as object expressions,
and deprecates parsing object expressions.