Test templates from MU co-located tests #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementing the nested components version simplifying the implementation Add tests for several complex module name cases allowing this to work with windows
2 tasks
Turbo87
changed the title
Turbo87
changed the title
mixonic
requested changes
Aug 22, 2018
lib/parse-module-name.js
Outdated
| if (collectionParts.length > 3) { | ||
| collectionParts.splice(-2); | ||
| return `${prefixString}/${collectionParts.join('/')}/template.hbs`; | ||
| } |
There was a problem hiding this comment.
@Turbo87 left a comment asking for this to be reformatted:
https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile/pull/33/files#r188862447
There was a problem hiding this comment.
His comment also asks for a test in these as-of-yet-untested cases:
emberconf/src/ui/routes/foo.jsshould returnnullwhen parsedemberconf/src/ui/components/foo-bar.jsshould returnnullwhen parsed
mixonic
approved these changes
Aug 23, 2018
|
Merging this! We can hack on it in master. |
NullVoxPopuli
deleted the
feature/continuation-of-test-private-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #33