Use broccoli-test-helper to make tests easier to work with #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
changed the title
rwjblue
requested changes
Oct 28, 2020
lukemelia
force-pushed
the
adopt-broccoli-fixture
branch
from
988e508
to
8b9b665
Compare
lukemelia
changed the title
- node 10 is the oldest maintained version of node as of this writing
- Update mocha to support async/await tests, too - Adds chai for nicer assertion syntax
lukemelia
force-pushed
the
adopt-broccoli-fixture
branch
from
8b9b665
to
d7026ce
Compare
|
Thanks. I've rebased on revised #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the time since tests were first written for this plugin, broccoli-test-helper was created, which allows describing input and expected output directories in code in the test body. This improves the readability and ability to manage the tests.
Once this is merged, I have some other improvements that build on top of it to modernize this addon and optionally enable caching. This is part of build performance work funded by @PrecisionNutrition.