Allow opt-in to caching. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukemelia
commented
Nov 1, 2020
lukemelia
commented
- Caching has historically been disabled for this plugin because of the difficulty of managing cache keys that would be invalidated by the contents of assets changing. Using this plugin in other contexts, such as broccoli-asset-prepend, don't share this problem, and should be able to enable caching to improve performance.
- Caching has historically been disabled for this plugin because of the difficulty of managing cache keys that would be invalidated by the contents of assets changing. Using this plugin in other contexts, such as broccoli-asset-prepend, don't share this problem, and should be able to enable caching to improve performance.
rwjblue
requested changes
Nov 3, 2020
- uses broccoli-test-helper's "changes" feature
|
@rwjblue This is ready to go from my POV. Let me know what you think. |
rwjblue
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.