-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not accepting nested configurations #26
Comments
I've added |
I'm noticing the same thing -- will investigate further soon. |
Issue is slightly but not directly related to https://github.com/jonathanKingston/broccoli-lint-eslint/blob/master/lib/index.js#L80 (which is modified by #25). Basically, we are using For this to work for us, we basically need to be able to call var config = this.cli.getConfigForFile(pathToFile);
this.cli.options = config;
this.cli.executeOnText(contents, pathToFile); But it really seems odd that the ESLint side doesn't expose this without ^^ ugliness. Maybe we can ping them? @nickiaconis - Also, RE: broccoli-persistent-filter, we would want to use |
I’ve been trying to reproduce this within the test suite for I pushed up the branch that I created for starting to dig in to this if anyone else is curious, and I’d expect https://github.com/jonathanKingston/broccoli-lint-eslint/blob/fix-nested-configuration-errror/test/test.js#L22 to fail on the nested fixture/config that I created without yet implementing any changes to the way But it passes. And, when I log out the return value for |
@rwjblue When you include a |
Should be fixed after #25 |
While developing ember-cli/ember-cli-eslint#41, I initially bumped the
broccoli-lint-eslint
version to2.0.1
, just to see if that changed anything. I noticed that any files within thetests/
directory of the Ember app I was testing against were no longer using the.eslintrc
file undertests/.eslintrc
to overwrite the configuration provided by the config file in the root of the app. So, certain files that were passing before were failing after updating this dependency, and passed again after reverting to the original version.The text was updated successfully, but these errors were encountered: