-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use broccoli-persistent-filter #21
Conversation
EslintValidationFilter.prototype.processString = function processString(content, relativePath) { | ||
'use strict'; // eslint-disable-line strict | ||
EslintValidationFilter.prototype.baseDir = function baseDir() { | ||
return process.cwd(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generally __dirname
}; | ||
|
||
EslintValidationFilter.prototype.cacheKeyProcessString = function cacheKeyProcessString(content, relativePath) { | ||
return md5Hex([content, relativePath, JSON.stringify(this.options)]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use json-stable-stringify as the unordered json stringify busts the cache incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to handle the testGenerator function manually here, I think
dcc6dd0
to
7ca5a74
Compare
@rwjblue Good points. I've addressed them, and this should be ready for another review. |
7ca5a74
to
518fcd6
Compare
Added the result of |
@nickiaconis pinging for a heads-up about a few conflicts after merging #25. |
518fcd6
to
537d7a5
Compare
Thanks for the heads-up. Conflicts resolved. |
Hot on the heels of #14, here are the changes to use broccoli-persistent-filter. I've set it up to persist by default. It can be overridden by passing
{ persist: false }
as an option.Tests are passing: https://travis-ci.org/nickiaconis/broccoli-eslinter/builds/115196276Edit: This repo now leverages its own CI testing.