Use broccoli-persistent-filter #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EslintValidationFilter.prototype.processString = function processString(content, relativePath) { | ||
| 'use strict'; // eslint-disable-line strict | ||
| EslintValidationFilter.prototype.baseDir = function baseDir() { | ||
| return process.cwd(); |
Closed
| }; | ||
|
|
||
| EslintValidationFilter.prototype.cacheKeyProcessString = function cacheKeyProcessString(content, relativePath) { | ||
| return md5Hex([content, relativePath, JSON.stringify(this.options)]); |
There was a problem hiding this comment.
We need to use json-stable-stringify as the unordered json stringify busts the cache incorrectly
There was a problem hiding this comment.
We also need to handle the testGenerator function manually here, I think
nickiaconis
force-pushed
the
persistent-filter
branch
3 times, most recently
from
dcc6dd0
to
7ca5a74
Compare
|
@rwjblue Good points. I've addressed them, and this should be ready for another review. |
Merged
nickiaconis
force-pushed
the
persistent-filter
branch
from
7ca5a74
to
518fcd6
Compare
|
Added the result of |
|
@nickiaconis pinging for a heads-up about a few conflicts after merging #25. |
nickiaconis
force-pushed
the
persistent-filter
branch
from
518fcd6
to
537d7a5
Compare
|
Thanks for the heads-up. Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of #14, here are the changes to use broccoli-persistent-filter. I've set it up to persist by default. It can be overridden by passing
{ persist: false }as an option.Tests are passing: https://travis-ci.org/nickiaconis/broccoli-eslinter/builds/115196276Edit: This repo now leverages its own CI testing.