Invoke super with the valid args to avoid ENOENT #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Nov 7, 2017
|
I'm working on creating a failing test to reproduce the reported issue (before the fix) and confirming the fix corrects it. |
rwjblue
force-pushed
the
avoid-enoent-on-removal
branch
from
27332d3
to
b2c8376
Compare
|
Failing tests added and submitted as a separate PR so folks could review the CI run in #118. This PR was then rebased on top of that to show that the issue is properly being fixed. |
|
🎉 |
|
Thanks!! |
|
@rwjblue any objection to backporting this to 3.x for the sake of ember-cli users pre 2.14? |
|
Seems good to me! |
hjdivad
added a commit
that referenced
this pull request
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling super with only the
relativePathmeant thatbroccoli-persistent-filter's implementation ofgetDestinationPath(which callsisDirectory) could not properly no-op when the file has been removed.Fixes ember-cli/ember-cli#7347