Feature/update ignore filter message #30
Conversation
|
Hey! Thanks for this, it's been a while since I wrote that so makes sense it was broken. It looks like they have added the ability to ignore those by option now: This should mean that: https://github.com/jonathanKingston/broccoli-lint-eslint/blob/03a6d3f4934b11f7ac2d90c663c822dd372cf16f/lib/index.js#L71 can be changed to have a default of Either way there is only one line change here in this pull: https://github.com/jonathanKingston/broccoli-lint-eslint/pull/30/files if we are going with this option then this should be cleaned. If possible a test would be brilliant! |
|
I guess the option is for either ignore the |
|
Ah yeah, I think that was there before actually thanks! |
|
@jonathanKingston I just added tests cases. Let me know what do you think. |
|
@jonathansamines pinging for a heads-up about a few conflicts after merging #25. |
…ality was actually used.
|
@BrianSipple thanks for pinging. I solved the merging conflicts. |
| @@ -51,10 +51,11 @@ function filterIgnoredFileMessages(errors) { | |||
| function filterAllIgnoredFileMessages(result) { | |||
| const resultOutput = result; | |||
|
|
|||
| result.results.map((resultItem) => { | |||
| result.results.forEach((resultItem) => { | |||
| resultItem.messages = filterIgnoredFileMessages(resultItem.messages); | |||
| return resultItem; | |||
There was a problem hiding this comment.
It looks like this is just a leftover from using map, but with forEach, the return actually becomes unnecessary 😄.
Everything else looks good to go, though!
There was a problem hiding this comment.
Completely true, removed ;)
|
@jonathansamines Thanks! |
When the eslint@2 upgrade was made, the
filterIgnoredFileMessagesfunction was broken, since the new eslint@2 changed the message produced for the ignored files.Maybe somehow related to the reported error on ember-cli-eslint#44.