Dont lint ignored files #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasHill
commented
Mar 19, 2017
| @@ -21,7 +21,7 @@ const FIXTURES_PATH_ESLINTIGNORE_FOR_WARNING = path.resolve(process.cwd(), './te | |||
| const FIXTURES_PATH_ESLINTRC = path.join(FIXTURES_PATH, '.eslintrc.js'); | |||
| const FIXTURES_PATH_ESLINTRC_ALTERNATE = path.join(FIXTURES_PATH, '.eslintrc-alternate.js'); | |||
| const FIXTURE_FILE_PATH_ALERT = 'fixtures/alert.js'; | |||
| const JS_FIXTURES = fs.readdirSync(FIXTURES_PATH).filter((name) => /\.js$/.test(name)); | |||
| const JS_FIXTURES = fs.readdirSync(FIXTURES_PATH).filter((name) => /\.js$/.test(name) && !/^.eslintrc/.test(name)); | |||
There was a problem hiding this comment.
Before it was actually linting the eslintrc files. The eslint API considers these an "ignored file" by default, and they are no longer linted, so the count of JS_FIXTURES needed to be reduced to exclude them.
LucasHill
commented
Mar 19, 2017
| @@ -31,32 +30,6 @@ function getResultSeverity(resultMessages = []) { | |||
| }, 0); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This whole filtering logic is superseded by the new guard which keeps ignored files from being linted on at all. So it is no longer necessary. I kept the tests in to ensure however.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove some confusion around ignored files. Currently, all JS files will show up in the linter as "passed eslint" even if they were ignored. This changes that behavior and if a file is ignored, it never gets run through the linter, and doesn't show up in the test report.