This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
[ENHANCEMENT] Don't make assumptions about dataType and payload. #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the final goal of this is to become a service for making AJAX request, it would be a good idea not to make many assumptions about such request, AJAX does not necessarily mean json.
I'd like to propose we just expose the basic interface for jQuery.ajax without trying to be too smart about it. With this we also address issues like #2.
Also what about changing the the args of
service.request
to be ONLYurl
andoptions
, I think this provides better ergonomics that the current implementation, for example if I want to do a get with query params I'd have to do something likeservice.request(url, 'GET', {data: {foo: true}}
this could be reduce toservice.request(url, {data: {foo: true}}
sinceGET
tends to be the default, and then if I need a different request type, then I could just specify that in the options (like$.ajax
)