Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Chrome instead of PhantomJS to run tests #255

Merged
merged 1 commit into from Oct 15, 2018
Merged

Use Chrome instead of PhantomJS to run tests #255

merged 1 commit into from Oct 15, 2018

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Oct 14, 2018

Breaking.

Turbo87
Turbo87 reviewed Oct 14, 2018
View reviewed changes
.travis.yml Show resolved Hide resolved
Turbo87
Turbo87 reviewed Oct 14, 2018
View reviewed changes
.travis.yml Outdated
@@ -4,14 +4,18 @@ language: node_js
node_js:
- "6"

sudo: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already set on line 1

@Gaurav0 Gaurav0 force-pushed the drop_phantomjs branch 3 times, most recently from 8e00a2a to 9da551c Compare October 14, 2018 18:04
rwjblue
rwjblue reviewed Oct 15, 2018
View reviewed changes
.travis.yml Outdated
cache:
yarn: true

before_script:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this shouldn't be needed...

Copy link
Contributor Author

@Gaurav0 Gaurav0 Oct 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. It should be using the --no-sandbox and --headless mode. It isn't.

My two theories are that 1) it isn't finding/using testem.js and 2) it doesn't think it is in ci mode. I'm leaning toward (1).

Copy link
Member

@rwjblue rwjblue Oct 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly hardcoded resolutions forcing an older version of testem that isn't aware of the new syntax (nested ci property under Chrome section)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already tried forcing the latest testem. Let me try using an older syntax in testem.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue Yay that worked!

rwjblue
rwjblue reviewed Oct 15, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@Gaurav0 Gaurav0 mentioned this pull request Oct 15, 2018
Merged
@Turbo87
Copy link
Member

Turbo87 commented Oct 15, 2018

@Gaurav0 can you squash the commits so that the history is a little easier to read?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Oct 15, 2018

Sure thing.

@Gaurav0
Drop support for phantomjs
9e37906 
fix node tests

use trusty

try something

add logs

try something else

try another thing

try using node 8

try yet another thing

more logs

fix suid error

use xvfb

cleanup logs

revert path changes

try forcing latest version of testem

try removing comments in travis.yml

revert try forcing latest version of testem

try older syntax in testem.js

don't need sudo
@Turbo87 Turbo87 changed the title Drop support for phantomjs Use Chrome instead of PhantomJS to run tests Oct 15, 2018
@Turbo87 Turbo87 merged commit b015986 into ember-cli:master Oct 15, 2018
@Gaurav0 Gaurav0 deleted the drop_phantomjs branch October 15, 2018 18:23
bors bot added a commit to danmcclain/ember-deferred-content that referenced this pull request Nov 9, 2018
@bors @greenkeeper
Merge #53
d2396b4 
53: Update ember-cli-eslint to the latest version 🚀 r=danmcclain a=greenkeeper[bot]


## The devDependency [ember-cli-eslint](https://github.com/ember-cli/ember-cli-eslint) was updated from `4.2.3` to `5.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v5.0.0</summary>

<h4><g-emoji class="g-emoji" alias="boom" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f4a5.png">💥</g-emoji> Breaking Change</h4>
<ul>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/284" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/284/hovercard">#284</a> Upgrade <code>broccoli-lint-eslint</code> to v5.0.0 (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/256" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/256/hovercard">#256</a> Drop support for IE9 and IE10 (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/254" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/254/hovercard">#254</a> Drop support for Node.js 4 (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
</ul>
<h4><g-emoji class="g-emoji" alias="house" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f3e0.png">🏠</g-emoji> Internal</h4>
<ul>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/251" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/251/hovercard">#251</a> Upgrade to ember cli 3.4 via ember-cli-update (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/255" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/255/hovercard">#255</a> Use Chrome instead of PhantomJS to run tests (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/263" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/263/hovercard">#263</a> Remove obsolete <code>es6-promise</code> dev dependency (<a href="https://urls.greenkeeper.io/Turbo87">@Turbo87</a>)</li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/pull/262" data-hovercard-type="pull_request" data-hovercard-url="/ember-cli/ember-cli-eslint/pull/262/hovercard">#262</a> yarn: Add <code>integrity</code> hashes (<a href="https://urls.greenkeeper.io/Turbo87">@Turbo87</a>)</li>
</ul>
<h4>Committers: 2</h4>
<ul>
<li>Gaurav Munjal (<a href="https://urls.greenkeeper.io/Gaurav0">@Gaurav0</a>)</li>
<li>Tobias Bieniek (<a href="https://urls.greenkeeper.io/Turbo87">@Turbo87</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 68 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/3b7f29605a727c3f84d6f7652ded7ff97e83604c"><code>3b7f296</code></a> <code>v5.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/0beb1151e51af3864b5beef3e69ded4932d7181f"><code>0beb115</code></a> <code>Update Changelog</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/5c23ac0bb4782d227e1e59dadbbff66e732238c9"><code>5c23ac0</code></a> <code>Add <code>lerna-changelog</code> dev dependency</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/5657eecc4ae9395029be54db0b7eb96d05c0ea67"><code>5657eec</code></a> <code>Merge pull request #284 from Gaurav0/eslint_5</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/0d484e6d64248499d0007ae7881e9a690ece1025"><code>0d484e6</code></a> <code>Upgrade to broccoli-lint-eslint 5</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/4f88dbc23f0d8fe20e113fb05c3aa08d3e361885"><code>4f88dbc</code></a> <code>Bump qunit-dom from 0.7.1 to 0.8.0 (#287)</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/6da2ee24d74575df66a65c27351b1090b442ef18"><code>6da2ee2</code></a> <code>Merge pull request #286 from ember-cli/dependabot/npm_and_yarn/lodash-4.17.11</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/50645c3ef0248f225f07863ac72f06becd8b0d0c"><code>50645c3</code></a> <code>[Security] Bump lodash from 4.17.4 to 4.17.11</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/d48f347c7bf338081919d370005dc5b257a95cf9"><code>d48f347</code></a> <code>Merge pull request #285 from ember-cli/dependabot/npm_and_yarn/debug-2.6.9</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/89101ac2596aa9ad0778152ee6eb7099f0b4c69e"><code>89101ac</code></a> <code>[Security] Bump debug from 2.6.3 to 2.6.9</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/92d4394c3667b3e38f1a18e234d4de11b073e13b"><code>92d4394</code></a> <code>Merge pull request #251 from Gaurav0/upgrade_to_ember_cli_3_4</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/7b01707044da0653db32a9900c46559d7cbf9659"><code>7b01707</code></a> <code>fix typo</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/293abba13f91f8376e6c862b9fe6b78d8b7ddc16"><code>293abba</code></a> <code>remove chai-things</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/1810da28a4a96928f3307e134b086d76ae13fed3"><code>1810da2</code></a> <code>address comments</code></li>
<li><a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/commit/3948b782e05e0b693fedfae70346d6ae7ec6c342"><code>3948b78</code></a> <code>Do not fork tap reporter / match regexes</code></li>
</ul>
<p>There are 68 commits in total.</p>
<p>See the <a href="https://urls.greenkeeper.io/ember-cli/ember-cli-eslint/compare/a0e0ac2f48ae338ee085f2fd0a5813cacdad3c6d...3b7f29605a727c3f84d6f7652ded7ff97e83604c">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gaurav0 @Turbo87 @rwjblue