This repository has been archived by the owner on Feb 6, 2021. It is now read-only.
Fix for Memory leak #112
Merged
Fix for Memory leak #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
added a commit
to ember-cli/ember-cli-htmlbars
that referenced
this pull request
Oct 4, 2018
stefanpenner
added a commit
to ember-cli/ember-cli-htmlbars
that referenced
this pull request
Oct 4, 2018
stefanpenner
added a commit
to ember-cli/ember-cli-htmlbars
that referenced
this pull request
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier
templateCompilerPathwas deleted from require.cache alone. But there will be a reference in parent.children as well which was not deleted. This caused a memory leak. Especially when all babel processing runs in parallel, the memory bloated to as big as 7GB for 1 worker alone for an ember application combined with couple of Gigs from other workers, it threwheap out of space.But deleting the parent reference as well (or not removing the require cache for templateCompilerPath every time) causes the workers to consume only a maximum of 200 MB for the same application.
It is surfacing now because,
AstPlugin.setupis called fromlib/require-from-worker.jsas part of babel parallelization.Only when babel parallelization works completely in an app and number of modules to transpile is huge, the number of calls to
AstPlugin.setupis also huge and we getheap out of space.Apps with non parallel babel processing does not go through
AstPlugin.setupor the number of calls to it is minimum that we don't getheap out of space.@rwjblue