This repository has been archived by the owner on Feb 6, 2021. It is now read-only.
Add helpful messaging when used in the wrong context. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
May 2, 2017
index.js
Outdated
| this._super.init.apply(this, arguments); | ||
|
|
||
| let checker = new VersionChecker(this); | ||
| let hasCorrectBabelVersion = checker.for('ember-cli-babel').gt('6.0.0-alpha.1'); |
There was a problem hiding this comment.
6.0.0-alpha.1 itself needs 0.3 too?
There was a problem hiding this comment.
No, I just picked it as the lower bounds and I couldn't recall if .gte is supported 😜
There was a problem hiding this comment.
yep, .gte() exists. or use .lt() here too and rename the variable 😉
rwjblue
force-pushed
the
add-helpful-messaging
branch
from
6620686
to
d82e88a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.