This repository has been archived by the owner on Feb 6, 2021. It is now read-only.
Ensure ember-template-compiler does not mutate shared config object. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During evaluation of `EmberENV` Ember internally mutatest the object (setting defaults and whatnot). This change prevents the mutation from modifying the actual configuration embedded into the final assets.
rwjblue
force-pushed
the
prevent-mutation-of-config
branch
from
2e4d6e0
to
ec57510
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During evaluation of
EmberENVEmber internally mutates the object (setting defaults and whatnot). This change prevents the mutation from modifying the actual configuration embedded into the final assets.Related to failing tests in ember-cli/ember-cli#7270.