Ensure inline precompilation does not error when a template contains */
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
*/
Prior to this a template like:
```js
hbs`some content */`
```
Would emit invalid JS:
```js
Ember.HTMLBars.template(
/*
some content */
*/
{
// some stuff emitted by actual compilation
}
)
```
The comment showing the original template was added as a
developer aide (makes looking at files with many inline
templates such as tests much easier), but without
escaping `*/` we risk the template content itself
breaking the JS parsing within the file.
This commit ensures that `*/` is escaped to `*\/` which
avoids the issue.
rwjblue
force-pushed
the
update-babel-plugin
branch
from
d30ae7f
to
eb2d165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update babel-plugin-htmlbars-inline-precompile to 3.0.1 to fix an issue with inline templates containing
*/.Prior to this a template like:
Would emit invalid JS:
The comment showing the original template was added as a developer aide (makes looking at files with many inline templates such as tests much easier), but without escaping
*/we risk the template content itself breaking the JS parsing within the file.This commit ensures that
*/is escaped to*\/which avoids the issue.Fixes #391