Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprints: Add start/destroy-app test helper files #239

Merged
merged 1 commit into from Jan 28, 2018
Merged

blueprints: Add start/destroy-app test helper files #239

merged 1 commit into from Jan 28, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 21, 2018 •
edited

These files were removed in ember-cli/ember-cli#7546, but ember-cli-mocha (and ember-mocha) still need them.

see also #237 (comment)

An alternative would be to add them to the acceptance-test blueprint in Ember.js itself for the ember-cli-mocha case 馃

@Turbo87 Turbo87 added the bug label Jan 21, 2018
@Turbo87 Turbo87 requested a review from rwjblue January 21, 2018 13:37
@Turbo87 Turbo87 mentioned this pull request Jan 21, 2018
Closed
@Turbo87 Turbo87 merged commit b5cec06 into ember-cli:v0.14.x Jan 28, 2018
@Turbo87 Turbo87 deleted the add-test-helpers branch January 28, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Turbo87