Generate a component integration test by default. #64
Conversation
| Install ember-cli-mocha: | ||
|
|
||
| ```sh | ||
| npm install ember-cli-mocha --save-dev | ||
| ember generate ember-cli-mocha | ||
| ember install ember-cli-mocha |
There was a problem hiding this comment.
ember install will run the blueprint, so no need for two steps.
|
cc @rwjblue |
| " this.render();\n" + | ||
| testContent = "// creates the component instance" + EOL + | ||
| " var component = this.subject();" + EOL + | ||
| " expect(component._state).to.equal('preRender');" + EOL + EOL + |
There was a problem hiding this comment.
Checking _state was removed in ember-cli/ember-cli#4384, can this be updated to reflect that?
|
Left one small comment, but looks good to me otherwise. |
|
Sounds good, thanks for looking. I've made the requested change. |
|
@blimmer looks good to me as well - thanks for all your work. Would you mind either removing the version bump from package.json or make it as a separate final commit simply labeled |
This commit brings ember-cli-mocha up to date with ember-cli ember-cli/ember-cli#4272 Fixes ember-cli#58.
blimmer
force-pushed
the
component-integration-test-by-default
branch
from
c220193
to
24e5927
Compare
…ault Generate a component integration test by default.
|
Perfect - thanks again @blimmer! Just published v0.9.0. |
|
👍 - Thank you for your hard work on this! |
This commit brings ember-cli-mocha up to date with ember-cli ember-cli/ember-cli#4272
Fixes #58.