Support beta/canary version number format #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should support beta and canary version formats in the form of `2.3.0-beta.2+41030996`, since tools like `ember try:testall` will attempt to pull down prerelease versions that don't yet have strictly semver compatible numbers.
|
I want the version to match what is actually being used. The issue is mostly that the semver package does not consider prereleases to satisfy a non-prerelease range. We can fix the isAbove helper to use gt instead of satisfies, but I'm not sure if the upstream lib you are using uses isAbove or something else. |
|
Also, that version number listed in the description is a semver compliant version number (but it may not match when using "semver.satisfies(this.version, '> 1.13.0')"). |
|
The check the upstream app is trying to do is: checker.for('ember', 'bower').assertAbove('1.13.7');so changing |
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Dec 15, 2015
Support beta/canary version number format
|
Released as v1.1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should support beta and canary version formats in the form of
2.3.0-beta.2+41030996, since tools likeember try:testallwill attempt to pull down prerelease versions that don't (yet) have strictly semver compatible numbers.