Add hasSingleImplementation, assertHasSingleImplementation (highlander) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the lint error, they are passing locally. |
|
Ran |
xg-wang
changed the title
|
I cannot think about a case I need |
stefanpenner
requested changes
Jan 15, 2020
stefanpenner
requested changes
Jan 15, 2020
|
@stefanpenner thx, agree with your reviews.
|
stefanpenner
requested changes
Jan 16, 2020
stefanpenner
force-pushed
the
highlander
branch
from
6fc74e5
to
06f06ed
Compare
rwjblue
reviewed
Jan 16, 2020
stefanpenner
force-pushed
the
highlander
branch
5 times, most recently
from
e1bc141
to
91e9d6d
Compare
stefanpenner
changed the title
stefanpenner
force-pushed
the
highlander
branch
3 times, most recently
from
f93c038
to
cdd3a85
Compare
rwjblue
reviewed
Jan 16, 2020
stefanpenner
force-pushed
the
highlander
branch
3 times, most recently
from
75f5d04
to
bb046cf
Compare
stefanpenner
approved these changes
Jan 17, 2020
rwjblue
reviewed
Jan 17, 2020
stefanpenner
force-pushed
the
highlander
branch
4 times, most recently
from
00df6fe
to
711d3a3
Compare
rwjblue
approved these changes
Jan 17, 2020
This checker is specific to asserting and checking scenarios not against a single level, but rather project wide.
Functionality:
* `VersionChecker.forProject(project).{hasSingleImplementation,assertSingleImplementation}('addon-name'); // => true|false`
* `VersionChecker.forProject(project).filterAddonByName('addon-name'); // => addon[]`
* `VersionChecker.forProject(project).allAddons(); // iterator across
all addons (dfs)
stefanpenner
force-pushed
the
highlander
branch
from
711d3a3
to
454cb71
Compare
stefanpenner
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where the addon has build registry so that it needs to be listed as
dependenciesin other addons that uses it, but it brings in additional assets.ember-cli does the "firstWriteWins" strategy, but I need to assert there's no duplication in node_modules that surprises the final build.
Comparing to emberjs/ember-test-waiters#86, this checker does not mutate anything in the hierarchy but rather throws a silent error to force app fixes the resolution.