Remove Un-needed features #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jan 16, 2020
* bower support: bower doesn’t even support itself any-longer * `forEmber` use `for(‘ember’)` instead * combine NPMDependencyVersionChecker with DependencyVersionChecker as we now only have once version checker (no more bower) * stop using `error.suppressStacktrace` as a replacement for SilentError as it does not do anything. If we really want SilentError we should use it directly, although right now that existence of the stack is actually useful.
bantic
added a commit
to bantic/ember-cli-version-checker
that referenced
this pull request
Nov 27, 2020
Bower support [was removed](ember-cli#165) in the v5.0.0 release, but the README still had a few mentions of it. This removes those mentions. I tried to update the first example ("include different templates") to use a possibly-more-realistic version number as the pivot (3.4 is when angle bracket invocations were added). Also fix a small typo later in the README.
This was referenced Nov 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forEmberusefor(‘ember’)instead