Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasSingleImplementation #178

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix hasSingleImplementation #178

merged 1 commit into from
Mar 23, 2020

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Mar 22, 2020 •
edited 

it('#hasSingleImplementation detects singleton', function() {
  assert.ok(checker.hasSingleImplementation('foo'));

will fail without the fix in place

@rwjblue rwjblue added the bug label Mar 23, 2020
@rwjblue rwjblue merged commit 06b184d into ember-cli:master Mar 23, 2020
@rwjblue
Copy link
Member

rwjblue commented Mar 23, 2020

https://github.com/ember-cli/ember-cli-version-checker/releases/tag/v5.0.2

@xg-wang xg-wang deleted the single-implementation branch March 24, 2020 17:06
@xg-wang xg-wang restored the single-implementation branch March 24, 2020 17:07
@xg-wang xg-wang mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xg-wang @rwjblue