Add #forEmber helper method to get ember version from bower or npm #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, can you update to check npm first and fallback to bower? |
josemarluedke
force-pushed
the
feature/for-ember
branch
8 times, most recently
from
a3e9710
to
c60070e
Compare
|
Updated @rwjblue! |
|
looks like this needs a rebase |
josemarluedke
force-pushed
the
feature/for-ember
branch
from
c60070e
to
123d952
Compare
|
Rebased @stefanpenner. |
|
I just realized there are no readme updates here, would you mind adding a blurb so folks can discover this helper function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method
forEmberthat will look foremberin bower, if it does not find it, this will look forember-sourcein NPM.cc/ @rwjblue