Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous file I/O when checking the same package version #242

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

davecombs
Copy link

No description provided.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I left one small additional improvement comment inline.

src/dependency-version-checker.js Outdated Show resolved Hide resolved
@rwjblue rwjblue changed the title remove most file I/O in dependency-version-checker.js Remove extraneous file I/O when checking the same package version Jan 19, 2021
@rwjblue rwjblue merged commit dd7fbf9 into ember-cli:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants