Ensure forEmber _always_ uses the project.
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes _significant_ issues when linking...
pzuraq
approved these changes
Apr 27, 2018
rwjblue
commented
Apr 27, 2018
| module.exports = function(input) { | ||
| if (input.project) { | ||
| return input.project; | ||
| } else if (input.root && typeof input.isEmberCLIProject === 'function') { |
There was a problem hiding this comment.
FWIW, I decided to use the presence of this function as a way to confirm we were given the project directly because I can easily imagine a future refactor in ember-cli that would only setup bowerDirectory if a bower.json was detected...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes significant issues when linking...