Support resolution with Yarn PnP. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
commented
Jan 2, 2019
Turbo87
reviewed
Jan 2, 2019
| } catch (e) { | ||
| if (e.code === 'MODULE_NOT_FOUND') { | ||
| if (ALLOWED_ERROR_CODES.includes(e.code)) { |
There was a problem hiding this comment.
we should probably use debug or heimdall-logger here to make this easier to debug
There was a problem hiding this comment.
Ya, good point. I'll do that in a separate PR then rebase this one...
|
CI failure is due to not running recent enough yarn version in CI. #81 should fix. |
rwjblue
force-pushed
the
pnp-support
branch
3 times, most recently
from
6a17cbf
to
83cb1c1
Compare
Yarn 1.12.x supports the new PnP system to allow folks to avoid having a `node_modules/` folder in _each_ project. To implement this, they create a static file mapping table for each package and then require them directly from the global Yarn cache. Since a PnP project is no longer following the "normal" node module resolution rules changes were needed in the `resolve` package. Those changes landed in `resolve@1.9.0` and are leveraged by Yarn 1.13.0+. In the mean time (throughout the Yarn 1.12.x lifespan), a simple `resolve.sync` isn't quite good enough so we now detect if we are running in a PnP scenario (by attempting to require the `pnpapi` module). If we are, we use the public API provided by Yarn's `pnpapi` module to resolve the package being checked for relative to the provided root.
|
@Turbo87 - no, you are right it was a node 6 issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn 1.12.x supports the new PnP system to allow folks to avoid having a
node_modules/folder in each project. To implement this, they create a static file mapping table for each package and then require them directly from the global Yarn cache.Since a PnP project is no longer following the "normal" node module resolution rules changes were needed in the
resolvepackage. Those changes landed inresolve@1.9.0and are leveraged by Yarn 1.13.0+.In the mean time (throughout the Yarn 1.12.x lifespan), a simple
resolve.syncisn't quite good enough so we now detect if we are running in a PnP scenario (by attempting to require thepnpapimodule). If we are, we use the public API provided by Yarn'spnpapimodule to resolve the package being checked for relative to the provided root.Fixes #78.
Related to ember-cli/ember-cli#8164.