Skip to content

Commit

Permalink
Update app/addon blueprints to ember-auto-import@2
Browse files Browse the repository at this point in the history
Quick Summary of Breaking Changes
---------------------------------

- apps that have custom webpack config will need to check that their config is compatible with webpack 5
- apps must add webpack to their own dependencies (`yarn add --dev webpack@5` or `npm install --save-dev webpack@5`)
- apps that were adding css handling (like `css-loader`, `style-loader`, and `MiniCSSExtraPlugin`) to the webpack config must remove those, because they're now included by default for compatibility with the embroider v2 package spec.
- apps should confirm that their deployment strategy includes all files produced under `dist` (not just the traditional expected ones like `dist/assets/your-app.js` and `dist/assets/vendor.js`)
- apps that use `fingerprint.prepend` to move their assets to a different origin will also need to set `autoImport.publicAssetURL`. See example below.
- addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade
- our `alias` option has changed slightly to align better with how it works in webpack
- we dropped support for node < 12 and ember-source < 3.4 and ember-cli < 3.4.

For more details read the 2.0 upgrading guide here:

https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md
  • Loading branch information
rwjblue committed Sep 15, 2021
1 parent 39dcf21 commit 20b71db
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 19 deletions.
6 changes: 3 additions & 3 deletions blueprints/app/files/package.json
Expand Up @@ -32,7 +32,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -61,8 +61,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0<% if (embroider) { %>",
"webpack": "^5.51.1<% } %>"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
5 changes: 3 additions & 2 deletions tests/fixtures/addon/defaults/package.json
Expand Up @@ -37,7 +37,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-inject-live-reload": "^2.1.0",
Expand All @@ -63,7 +63,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
5 changes: 3 additions & 2 deletions tests/fixtures/addon/yarn/package.json
Expand Up @@ -37,7 +37,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-inject-live-reload": "^2.1.0",
Expand All @@ -64,7 +64,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
5 changes: 3 additions & 2 deletions tests/fixtures/app/defaults/package.json
Expand Up @@ -29,7 +29,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -58,7 +58,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/app/embroider-no-welcome/package.json
Expand Up @@ -32,7 +32,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -61,7 +61,7 @@
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0",
"webpack": "^5.51.1"
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/app/embroider-yarn/package.json
Expand Up @@ -32,7 +32,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -62,7 +62,7 @@
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0",
"webpack": "^5.51.1"
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/app/embroider/package.json
Expand Up @@ -32,7 +32,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -62,7 +62,7 @@
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0",
"webpack": "^5.51.1"
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
5 changes: 3 additions & 2 deletions tests/fixtures/app/npm/package.json
Expand Up @@ -29,7 +29,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -57,7 +57,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down
5 changes: 3 additions & 2 deletions tests/fixtures/app/yarn/package.json
Expand Up @@ -29,7 +29,7 @@
"@glimmer/tracking": "^1.0.4",
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^1.11.3",
"ember-auto-import": "^2.2.0",
"ember-cli": "~<%= emberCLIVersion %>",
"ember-cli-app-version": "^5.0.0",
"ember-cli-babel": "^7.26.6",
Expand Down Expand Up @@ -58,7 +58,8 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"qunit": "^2.16.0",
"qunit-dom": "^1.6.0"
"qunit-dom": "^1.6.0",
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand Down

0 comments on commit 20b71db

Please sign in to comment.