Skip to content

Commit

Permalink
Make async/await work nicely.
Browse files Browse the repository at this point in the history
This change does a few things:

* Add `ember-maybe-import-regenerator` to the default blueprint.
* Drop IE9 from `config/targets.js`, and replace with IE11 (to match
  Ember 3.0.0's minimum browser requirements).
* Modify `config/targets.js` to make development builds target modern
  browsers.

This essentially brings over the configuration discussed in [this blog
post](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/):

* [Section 30](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/#install-maybe-install-regenerator)
* [Section 10](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/#limit-targets-locally)
  • Loading branch information
rwjblue committed Jan 11, 2018
1 parent 7a86445 commit 7798114
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 6 deletions.
20 changes: 14 additions & 6 deletions blueprints/app/files/config/targets.js
@@ -1,8 +1,16 @@
const browsers = [
'last 1 Chrome versions',
'last 1 Firefox versions',
'last 1 Safari versions'
];

const isCI = !!process.env.CI;
const isProduction = process.env.EMBER_ENV === 'production';

if (isCI || isProduction) {
browsers.push('ie 11');
}

module.exports = {
browsers: [
'ie 9',
'last 1 Chrome versions',
'last 1 Firefox versions',
'last 1 Safari versions'
]
browsers
};
1 change: 1 addition & 0 deletions blueprints/app/files/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~3.0.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-source": "~3.0.0-beta.1<% if (welcome) { %>",
"ember-welcome-page": "^3.0.0<% } %>",
Expand Down
1 change: 1 addition & 0 deletions blueprints/module-unification-app/files/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~2.18.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0<% if (welcome) { %>",
"ember-welcome-page": "^3.0.0<% } %>",
"eslint-plugin-ember": "^5.0.0",
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/addon/npm/package.json
Expand Up @@ -37,6 +37,7 @@
"ember-disable-prototype-extensions": "^1.1.2",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-source": "~3.0.0-beta.1",
"eslint-plugin-ember": "^5.0.0",
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/addon/yarn/package.json
Expand Up @@ -37,6 +37,7 @@
"ember-disable-prototype-extensions": "^1.1.2",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-source": "~3.0.0-beta.1",
"ember-welcome-page": "^3.0.0",
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/app/npm/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~3.0.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-source": "~3.0.0-beta.1",
"eslint-plugin-ember": "^5.0.0",
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/app/yarn/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~3.0.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-source": "~3.0.0-beta.1",
"ember-welcome-page": "^3.0.0",
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/module-unification-app/npm/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~2.18.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"eslint-plugin-ember": "^5.0.0",
"loader.js": "^4.2.3"
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/module-unification-app/yarn/package.json
Expand Up @@ -34,6 +34,7 @@
"ember-data": "~2.18.0-beta.1",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-resolver": "^4.0.0",
"ember-welcome-page": "^3.0.0",
"eslint-plugin-ember": "^5.0.0",
Expand Down

0 comments on commit 7798114

Please sign in to comment.