New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set prototype extensions to false by default for addons #3443
Comments
👍 |
1 similar comment
👍 |
arekt
pushed a commit
to mediweb/ember-spin-button
that referenced
this issue
Mar 9, 2016
Addons shouldn't rely on prototype extensions. related to ember-cli/ember-cli#3443
arekt
pushed a commit
to mediweb/ember-spin-button
that referenced
this issue
Mar 10, 2016
Addons shouldn't rely on prototype extensions. related to ember-cli/ember-cli#3443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See: https://github.com/dockyard/ember-validations/blob/master/tests/dummy/config/environment.js#L10
In ember-validations I have disabled prototype extension for the test suite. I believe that all addons should be developed with prototype extensions turned off to ensure the widest compatibility with how Ember is being used.
I don't have the time to add this into ember-cli, if anyone else wants to tackle that would be great. I'm not sure how best to accomplish this but the addon generator should be relying upon the
config/environment.js
from the app generator then modify theEmberENV
object in the file to disable prototype extensions rather than generating its own file.The text was updated successfully, but these errors were encountered: