Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set prototype extensions to false by default for addons #3443

Closed
bcardarella opened this issue Mar 6, 2015 · 2 comments · Fixed by #3645
Closed

Set prototype extensions to false by default for addons #3443

bcardarella opened this issue Mar 6, 2015 · 2 comments · Fixed by #3645
Assignees

Comments

@bcardarella
Copy link
Contributor

See: https://github.com/dockyard/ember-validations/blob/master/tests/dummy/config/environment.js#L10

In ember-validations I have disabled prototype extension for the test suite. I believe that all addons should be developed with prototype extensions turned off to ensure the widest compatibility with how Ember is being used.

I don't have the time to add this into ember-cli, if anyone else wants to tackle that would be great. I'm not sure how best to accomplish this but the addon generator should be relying upon the config/environment.js from the app generator then modify the EmberENV object in the file to disable prototype extensions rather than generating its own file.

@hhff
Copy link

hhff commented Mar 6, 2015

👍

1 similar comment
@stefanpenner
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants